π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in Statistics page#1
π‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in Statistics page#1
Conversation
Co-authored-by: silidev <16080894+silidev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: DOM-based XSS in
Statistics.ktwhereselectedDeckNamewas interpolated directly into a JavaScript string without escaping.π― Impact: A malicious deck name (e.g. from a shared deck) could execute arbitrary JavaScript in the context of the Statistics page.
π§ Fix: Used
JSONObject.quote(selectedDeckName)to properly escape the string before inserting it into the JS code.β Verification: Ran
StatisticsTest(testPlayDebugUnitTest) and verified it passes. Logic verification:JSONObject.quoteensures the string is a valid JSON string literal, preventing breakout.PR created automatically by Jules for task 14964980279173920377 started by @silidev