Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in Statistics page#1

Open
silidev wants to merge 1 commit intomainfrom
sentinel-fix-xss-statistics-14964980279173920377
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS vulnerability in Statistics page#1
silidev wants to merge 1 commit intomainfrom
sentinel-fix-xss-statistics-14964980279173920377

Conversation

@silidev
Copy link
Owner

@silidev silidev commented Feb 22, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: DOM-based XSS in Statistics.kt where selectedDeckName was interpolated directly into a JavaScript string without escaping.
🎯 Impact: A malicious deck name (e.g. from a shared deck) could execute arbitrary JavaScript in the context of the Statistics page.
πŸ”§ Fix: Used JSONObject.quote(selectedDeckName) to properly escape the string before inserting it into the JS code.
βœ… Verification: Ran StatisticsTest (testPlayDebugUnitTest) and verified it passes. Logic verification: JSONObject.quote ensures the string is a valid JSON string literal, preventing breakout.


PR created automatically by Jules for task 14964980279173920377 started by @silidev

Co-authored-by: silidev <16080894+silidev@users.noreply.github.com>
@google-labs-jules
Copy link

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant