Skip to content

Conversation

@sile
Copy link
Owner

@sile sile commented Sep 4, 2025

No description provided.

@sile sile requested a review from Copilot September 4, 2025 00:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Rust's reference-counted smart pointers (Rc and Arc) in JSON serialization and deserialization operations. The implementation allows JSON values to be parsed into and formatted from these smart pointer types.

  • Added TryFrom implementations for Rc<T> and Arc<T> to enable JSON deserialization
  • Added DisplayJson implementations for both smart pointer types to enable JSON serialization

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/try_from_impls.rs Added TryFrom trait implementations for Rc<T> and Arc<T> types, enabling JSON deserialization into smart pointers
src/display_json.rs Added DisplayJson trait implementations for Rc<T> and Arc<T> types, enabling JSON serialization from smart pointers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sile sile merged commit bb72805 into main Sep 4, 2025
9 checks passed
@sile sile deleted the rc-arc branch September 4, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants