Please pull from my fork#1
Closed
LudovicRousseau wants to merge 9 commits intosignal11:masterfrom
LudovicRousseau:master
Closed
Please pull from my fork#1LudovicRousseau wants to merge 9 commits intosignal11:masterfrom LudovicRousseau:master
LudovicRousseau wants to merge 9 commits intosignal11:masterfrom
LudovicRousseau:master
Conversation
Avoids a crash if libusb_get_active_config_descriptor() returns with an error code.
kCFNumberSInt32Type is expecting a Thirty-two-bit, signed integer. long is 64-bits on a 64-bits CPU so is the source of problems, especially on a big endian CPU.
The problem is that the file descriptor 1 used by printf() may not be stdout but somethink else. For example a daemon may close fds 0, 1 and 2 and reuse them to open files or sockets. So using printf() may send data on a file or socket opened by the application. Errors will now be logged to stderr only if DEBUG_PRINTF is defined.
Use the classic #ifndef __HIDAPI_H__ #define __HIDAPI_H__ ... #endif
Use HIDAPI_H__ instead of __HIDAPI_H__
Do not fail if the files to remove do not exist
*.o does not match ../hidtest/hidtest.o so we must use an explicit list of .o file names
Contributor
Author
|
Now merged. |
signal11
pushed a commit
that referenced
this pull request
Sep 20, 2016
Problem reported by the Coverity tool CID 1042532 (#1 of 1): Unchecked return value from library (CHECKED_RETURN)2. check_return: Calling function "fstat(dev->device_handle, &s)" without checking return value. This library function may fail and return an error code.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alan,
I now try to use github. I have 2 commits ahead of your repository. Please pull from my repo.
If you prefer patches by mail instead just tell me.