Skip to content
This repository was archived by the owner on Oct 26, 2022. It is now read-only.
/ Prism Public archive

Add basic WYSIWYG edit option#51

Draft
dseebacher wants to merge 1 commit intosiavashs:masterfrom
dseebacher:master
Draft

Add basic WYSIWYG edit option#51
dseebacher wants to merge 1 commit intosiavashs:masterfrom
dseebacher:master

Conversation

@dseebacher
Copy link

This should help out with #38 but still has some bugs, so I would not merge it (yet).

Overall this should help to not break code any more on visual changes. There is still a bug of escaped { when editing in WYSIWYG and the editor UI would need some love.

changes

  • rendering of WYSIWYG without prism classes
  • had to change the soy namespace as it was clashing with Prism in js (worked fine in java) and fix the selector

@dseebacher dseebacher requested a review from siavashs as a code owner January 15, 2021 11:37
@dseebacher dseebacher marked this pull request as draft January 15, 2021 15:09
Copy link
Owner

@siavashs siavashs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just left a minor comment.
Looking forward to the final implementation.
Thanks for your contribution.

@@ -1,4 +1,4 @@
{namespace Prism.Macros.Code}
{namespace JiraPrism.Macros.Code}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this namespace rename necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no JS expert, but the prism lib seemed to overwrite the Prism object leading to unknown properties. JiraPrism was just a random pick. Feel free to try wit the original namespace, for me it didn't work.

@siavashs
Copy link
Owner

siavashs commented Apr 7, 2021

@dseebacher I spend some time to figure out where the \{ escaping is happening but failed.
Also searching for a similar issue did not lead me to any useful results (as always with Atlassian ecosystem).
Any hints what to try next?

@dseebacher
Copy link
Author

@siavashs sorry, I dropped working on this problem (and Atlassian development in general), maybe someone else can take that over.

@siavashs
Copy link
Owner

@siavashs sorry, I dropped working on this problem (and Atlassian development in general), maybe someone else can take that over.

No problem and thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants