Conversation
siavashs
left a comment
There was a problem hiding this comment.
Overall LGTM, just left a minor comment.
Looking forward to the final implementation.
Thanks for your contribution.
| @@ -1,4 +1,4 @@ | |||
| {namespace Prism.Macros.Code} | |||
| {namespace JiraPrism.Macros.Code} | |||
There was a problem hiding this comment.
Was this namespace rename necessary?
There was a problem hiding this comment.
I am no JS expert, but the prism lib seemed to overwrite the Prism object leading to unknown properties. JiraPrism was just a random pick. Feel free to try wit the original namespace, for me it didn't work.
|
@dseebacher I spend some time to figure out where the |
|
@siavashs sorry, I dropped working on this problem (and Atlassian development in general), maybe someone else can take that over. |
No problem and thanks for your contribution! |
This should help out with #38 but still has some bugs, so I would not merge it (yet).
Overall this should help to not break code any more on visual changes. There is still a bug of escaped
{when editing in WYSIWYG and the editor UI would need some love.changes