refactor(component-library)!: deprecate allowEmpty prop and make it true by default #1032
+90
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed allowEmpty prop from mt-number-field component and its tests. - Added warnings for deprecated allowEmpty prop usage in both true and false cases. - Updated default behavior to handle empty values without allowEmpty. - Adjusted mt-unit-field to remove allowEmpty prop reference.
gweiermann
requested review from
alastair-simon,
davidtraum,
fabianhueske and
jleifeld
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Jan 20, 2026
gweiermann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Deprecates
allowEmptyformt-number-field, sets its default totrue.Why?
See #1009.
How?
allowEmptyprop frommt-number-fieldcomponent and removed it from tests.trueandfalsecases.true.Testing?
trueorfalse.Anything Else?
Discussion in slack: https://shopware-ag.slack.com/archives/CBAS8D2GH/p1766159096610889
Closes #1009.