Fix crashes when attempting to navigate empty chart lists.#14
Merged
HastagGuigui merged 1 commit intoshellrhythm:mainfrom Feb 28, 2023
RealistikDash:main
Merged
Fix crashes when attempting to navigate empty chart lists.#14HastagGuigui merged 1 commit intoshellrhythm:mainfrom RealistikDash:main
HastagGuigui merged 1 commit intoshellrhythm:mainfrom
RealistikDash:main
Conversation
fixes division by zero errors when trying to navigate through an empty chart list
Member
|
Thanks for making a PR! Seems good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes crashes regarding navigation attempts through an empty chart list.
Pressing any arrow key while inside an empty charts list would result in a division by zero error (for up and down arrows) or an index error (for the right arrow).
This PR adds a check that checks for an empty chart in the input handler.