Use TURN server WebRTC configuration for new streaming options#261
Merged
Use TURN server WebRTC configuration for new streaming options#261
Conversation
Owner
shamanec
commented
Mar 6, 2026
shamanec
commented
- Also properly start/close WebDriverAgent testmanagerd using the device context
|
waiting for this !! ❤️ |
gifflet
previously requested changes
Mar 9, 2026
Collaborator
gifflet
left a comment
gifflet
left a comment
There was a problem hiding this comment.
I've reviewed the changes and left some inline comments with suggestions for improvement.
The DRY refactoring and the device.Context fix are solid improvements. The main blocker is the common/utils package importing provider/config — this breaks the dependency hierarchy and risks import cycles if hub ever uses common/utils.
gifflet
dismissed
their stale review
The submitted review was dismissed because its suggestions were not relevant enough
gifflet
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.