fix: add kilted to support list #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure this is right, maybe importing them from the generated r2r_rcl code is better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly just copy-pasted the
jazzyitems, and it at least compiles.The
rcl_init_timer2change seems like it will break pre-Jazzy ROS releases. I'm new to rust and don't know if there's a way to do "conditional compilation" with it to work around this?The change to how some of the error codes are imported seems to have been necessary because the generated version of
r2r_rcl/bindings/rcl_bindings.rsseems to now include some (all?) of the action error codes. I left it using the ones fromr2r_actionsin the interest of "minimal change", but I'm not sure if that is correct.I grabbed a copy of the generated version of
r2r_rcl/bindings/rcl_bindings.rsbut didn't commit it because it has a ton of changes, and committing a version of that doesn't seem to be critical to having the package work? I'm new to Rust so I don't know what best practices are here.