Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2070 +/- ##
==========================================
+ Coverage 83.81% 83.95% +0.13%
==========================================
Files 313 316 +3
Lines 55676 56556 +880
Branches 11606 11971 +365
==========================================
+ Hits 46665 47479 +814
- Misses 7810 7890 +80
+ Partials 1201 1187 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seladb
requested review from
Dimi1010,
clementperon,
egecetin and
tigercosmos
Dimi1010
reviewed
Feb 22, 2026
| Backend_Unknown, | ||
| }; | ||
|
|
||
| PostgresMessageType() : m_Value(Frontend_Unknown) |
Collaborator
There was a problem hiding this comment.
nit: can also be marked constexpr.
|
|
||
| private: | ||
| PostgresMessageOrigin m_MessageOrigin; | ||
| mutable std::vector<std::unique_ptr<PostgresMessage>> m_Messages; |
Collaborator
There was a problem hiding this comment.
Curious, why not use PointerVector<PostgresMessage>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new PostgreSQL Wire Protocol Layer (PostgresLayer) to PcapPlusPlus, enabling parsing of PostgreSQL network traffic. This is the protocol used by PostgreSQL clients and servers to communicate over TCP.
This PR only parses the Postgres messages. Creating messages will be done in subsequent PRs