Id field on Product should deserialize product_id instead of id?

[Bucimis]

segmentio/analytics-react-native#277 (mirrored Appboy/appboy-segment-android#25)

We have an issue where a mutual customer is expecting to be able to pass product_id as the Id field on product objects, but only id is working. I believe it's because when deserializing Product objects, the Android code is expecting id instead of product_id

analytics-android/analytics/src/main/java/com/segment/analytics/Properties.java

Line 391 in 006bd94

private static final String ID_KEY = "id";

(which eventually flows down to our integration https://github.com/Appboy/appboy-segment-android/blob/master/appboy-segment-integration/src/main/java/com/segment/analytics/android/integrations/appboy/AppboyIntegration.java#L263)

Is that understanding correct? I think this may only really come up with react native type integrations, where things aren't typed by integrators using the Java objects before being passed into Segment.

[prayansh]

Yea this seems like an oversight, i have filed an internal Jira to map id and product_id to the same value. But until that change is shipped, i would recommend users to map both id and product_id (just like you recommended here). I will post an update here once the change is shipped

[prayansh]

did not intend to close the issue 😓

[prayansh]

@Bucimis #761 should fix this issue. This change will be included in our next release