Fix Type-based Call-Graphs with Multiple Inheritance #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritejakv
approved these changes
Jul 27, 2025
Collaborator
sritejakv
left a comment
sritejakv
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks.
fabianbs96
merged commit e5e20ba
into
secure-software-engineering:development
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RTAResolver and CHAResolver give wrong results in some case of multiple inheritance.
When virtually calling a function through a receiver of a non-primary base-class (that is not the first base in case of multiple inheritance) the analysis may falsely use the (correct) virtual index on the vtable of the first base class, even if the receiver is one of the secondary bases.
It may make sense to merge #773 first.