Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support looking up any legacy sdss spectra available for a given target sdss_id. Adds a new
target/legacyendpoint that accepts an sdss_id value that queries the allspec table and returns all matching rows. By default, "legacy" is any sdss_phase < 5, but this is an optional input. Settingphase=0will return all rows from the allspec table.Also adds a new AllSpec pydantic response model. And adds new
build_legacy_pathwrapper function for returning a filepath on disk for legacy data, using the values from an allspec data row as input.