Skip to content

Conversation

@CodeLieutenant
Copy link
Contributor

Closes #410

Signed-off-by: Dusan Malusev <dusan@dusanmalusev.dev>
@CodeLieutenant CodeLieutenant added this to the v2.1.0 milestone Jul 17, 2025
@CodeLieutenant CodeLieutenant self-assigned this Jul 17, 2025
@CodeLieutenant CodeLieutenant added the enhancement New feature or request label Jul 17, 2025
@soyacz
Copy link
Collaborator

soyacz commented Jul 17, 2025

how do you test it?

@CodeLieutenant
Copy link
Contributor Author

CodeLieutenant commented Jul 17, 2025

how do you test it?

Really hard to test it. Only way is to do the release

@fruch
Copy link
Collaborator

fruch commented Jul 17, 2025

what do we expect this to do ? improve throughput of gemini is capable of doing ?

if so it should be clearly measured

I think that if it's less then 1% improvement, it's not worth our time.

@CodeLieutenant
Copy link
Contributor Author

what do we expect this to do ? improve throughput of gemini is capable of doing ?

if so it should be clearly measured

I think that if it's less then 1% improvement, it's not worth our time.

There is improvement up to 10% in some arias of the code, like in the generator and partitions. It optimized some parts where GC is running, putting thing on the stack instead of the heap which helped GC pauses, overall i think it will be between 2-5% improvement on the throughput, really hard to tell, until this is released.

Since it's not a big change, only slight change in release part there is no reason to not keep it, as Go advances they will add more optimizations that will be part of the PGO and thus improve it.

@fruch
Copy link
Collaborator

fruch commented Jul 17, 2025

what do we expect this to do ? improve throughput of gemini is capable of doing ?
if so it should be clearly measured
I think that if it's less then 1% improvement, it's not worth our time.

There is improvement up to 10% in some arias of the code, like in the generator and partitions. It optimized some parts where GC is running, putting thing on the stack instead of the heap which helped GC pauses, overall i think it will be between 2-5% improvement on the throughput, really hard to tell, until this is released.

Since it's not a big change, only slight change in release part there is no reason to not keep it, as Go advances they will add more optimizations that will be part of the PGO and thus improve it.

your estimation is 2-5%, if you think it's important enough, test in SCT before merging this change.
sync with @soyacz when we should try it.

I would recommend if it's below 1% we don't merge it

we shouldn't be doing guesswork and figuring it out after releasing, we should figure things our before merging the into the code.

@CodeLieutenant
Copy link
Contributor Author

what do we expect this to do ? improve throughput of gemini is capable of doing ?
if so it should be clearly measured
I think that if it's less then 1% improvement, it's not worth our time.

There is improvement up to 10% in some arias of the code, like in the generator and partitions. It optimized some parts where GC is running, putting thing on the stack instead of the heap which helped GC pauses, overall i think it will be between 2-5% improvement on the throughput, really hard to tell, until this is released.
Since it's not a big change, only slight change in release part there is no reason to not keep it, as Go advances they will add more optimizations that will be part of the PGO and thus improve it.

your estimation is 2-5%, if you think it's important enough, test in SCT before merging this change. sync with @soyacz when we should try it.

I would recommend if it's below 1% we don't merge it

we shouldn't be doing guesswork and figuring it out after releasing, we should figure things our before merging the into the code.

Will run a simple test with it

@CodeLieutenant CodeLieutenant modified the milestones: v2.1.0, Next Jul 17, 2025
@CodeLieutenant CodeLieutenant changed the base branch from master to next July 23, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make use of PGO

3 participants