Skip to content

Conversation

scriptex
Copy link
Owner

No description provided.

@scriptex scriptex added the enhancement New feature or request label Dec 18, 2020
@scriptex scriptex self-assigned this Dec 18, 2020
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

/* prettier-ignore */
--html: (
<input type="checkbox" id="menu" hidden />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.

@scriptex scriptex linked an issue Dec 18, 2020 that may be closed by this pull request
@scriptex scriptex merged commit ba970d3 into master Dec 18, 2020
@scriptex scriptex deleted the feature/redesign branch December 18, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add widgets from Codersrank
1 participant