fix boolean bug #59
Merged
fix boolean bug #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 81.01% 81.02% +<.01%
==========================================
Files 40 40
Lines 2091 2092 +1
==========================================
+ Hits 1694 1695 +1
Misses 397 397 |
Member
|
Could you please add a test case? |
kmike
reviewed
May 14, 2018
| @@ -0,0 +1,40 @@ | |||
| from webstruct.features.global_features import _add_pattern_features | |||
Member
There was a problem hiding this comment.
Would you mind testing Pattern class instead? It should be an easy change, but this way we'd be testing public API
Member
|
Thanks @Kebniss! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug fix that was included in my last PR. This fix is important and would like to merge it even if the extra features do end up to make it to master :)