ENH use xp.cumulative_sum and xp.searchsorted directly instead of stable_cumsum #31994
+10
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we need a changelog entry. It's unlikely there will ever be a numerical stability problem when summing explained variance ratios and I prefer to keep the code simple (no device specific upcast) if not needed. |
OmarManzoor
approved these changes
Aug 22, 2025
|
Just launched the CUDA CI to check it works fine before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR changes PCA to use
xp.cumulative_suminstead of our ownstable_cumsum. It also usesxp.searchsortedfrom the array API instead ofnp.searchsorted. For context please refer to the discussion in #31533Any other comments?