Skip to content

Conversation

ThibaultDECO
Copy link

@ThibaultDECO ThibaultDECO commented Aug 14, 2025

PowerTransformer: check_array shall be used for inverse_transform, not _check_input with validate_data.

Reference Issues/PRs

Fixes issue #31947

…t _check_input. Fixes issue scikit-learn#31947

PowerTransformer: check_array shall be used for inverse_transform, not _check_input. Fixes issue scikit-learn#31947
Copy link

github-actions bot commented Aug 14, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: c5845fc. Link to the linter CI: here

Keeping check_shape
Correct error message
Line too long
Formatting
@ThibaultDECO ThibaultDECO changed the title PowerTransformer: check_array shall be used for inverse_transform, not _check_input. FIX PowerTransformer: check_array shall be used for inverse_transform, not _check_input. Aug 14, 2025
@ogrisel
Copy link
Member

ogrisel commented Aug 25, 2025

Could you please add a non-regression test based on #31947?

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't remove the _check_input usage here. We just need to make sure it's doing the right thing.

This also needs tests and a changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants