-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[chore] Fix detecting available nightly versions in bisect script. #23802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[chore] Fix detecting available nightly versions in bisect script. #23802
Conversation
…po contains only artifacts published after 2025-08-18
The intent is to have maven central also accessible via the new repo, I had permission issues when configuring it during Scala Days and I haven't yet fixed them. This should cover for this PR. |
I belive the repo.scala-lang already can delegate to Maven Central for missing artifacts, however, in this case we're extracting the |
I'll let you see the |
@@ -133,7 +133,7 @@ object ValidationScript: | |||
def tmpScalaCliScript(command: String, args: Seq[String]): File = tmpScript(s""" | |||
|#!/usr/bin/env bash | |||
|export JAVA_HOME=${sys.props("java.home")} | |||
|scala-cli ${command} -S "$$1" --server=false ${args.mkString(" ")} | |||
|scala-cli ${command} --repository=https://repo.scala-lang.org/artifactory/maven-nightlies/ -S "$$1" --server=false ${args.mkString(" ")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a particularly great idea to pass the repository here, as it still won't be used everywhere it should.
The repository has already been added internally in Scala CLI and can be accessed via nightly:
The fix will be included in the next stable Scala CLI (working on it).
If we really want to fix the script before a stable Scala CLI is available, then a better idea would be to:
|scala-cli ${command} --repository=https://repo.scala-lang.org/artifactory/maven-nightlies/ -S "$$1" --server=false ${args.mkString(" ")} | |
|scala-cli --cli-version nightly ${command} -S "$$1" --server=false ${args.mkString(" ")} |
Or just wait a bit.
The new repo contains only artefacts published after 2025-08-18, we need to parse maven-matadata from the old repository to get the full list of available nightlyies