Add request and response size metrics #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProxyTrace is modeled after net/http/httptrace package, but it's intended to be attached to Proxy not individual requests - hence the API is slightly different. It's possible to replicate httptrace.ClientTrace API in ProxyTrace but it's not a goal at the moment. It's added as means of notifying users that request is fully processed and response is written but can be easily extended to other usecases.
Call traceWroteResponse() in writeResponse() and tunnel().
Use request and response modifiers to decorate bodies with measuring capabilities. Report results when response is sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #453