Add integration tests by frostming · Pull Request #66 · sarugaku/passa

frostming · 2019-09-20T02:35:49Z

No description provided.

Signed-off-by: Dan Ryan <dan@danryan.co>

- Also clean up python specifiers Signed-off-by: Dan Ryan <dan@danryan.co>

- Also add magic methods to MetaSet object - Super fast and efficient now due to set comparisons - Old method had sometimes thousands of the same pyspecs - This consolidates as it builds Signed-off-by: Dan Ryan <dan@danryan.co>

Signed-off-by: Dan Ryan <dan@danryan.co> Test fixes Signed-off-by: Dan Ryan <dan@danryan.co> Fix specifier dedup logic Signed-off-by: Dan Ryan <dan@danryan.co> Fix import Signed-off-by: Dan Ryan <dan@danryan.co> Fix tox Signed-off-by: Dan Ryan <dan@danryan.co>

Signed-off-by: Dan Ryan <dan@danryan.co> Add set operations and comparison methods to metasets Signed-off-by: Dan Ryan <dan@danryan.co> Add abstract extraction methods for marker cleanup Signed-off-by: Dan Ryan <dan@danryan.co> Add intersection method for PySpecs and smarter unions and creation Signed-off-by: Dan Ryan <dan@danryan.co> Simplify and cleanup metadata implementation Signed-off-by: Dan Ryan <dan@danryan.co>

Signed-off-by: Dan Ryan <dan@danryan.co>

codecov · 2019-09-20T06:15:57Z

Codecov Report

❗ No coverage uploaded for pull request base (add-tests@3ed2038). Click here to learn what that means.
The diff coverage is 48.89%.

@@             Coverage Diff              @@
##             add-tests      #66   +/-   ##
============================================
  Coverage             ?   54.72%           
============================================
  Files                ?       42           
  Lines                ?     2701           
  Branches             ?      475           
============================================
  Hits                 ?     1478           
  Misses               ?     1108           
  Partials             ?      115

Impacted Files	Coverage Δ
src/passa/cli/install.py	`0% <ø> (ø)`
src/passa/cli/options.py	`78.43% <ø> (ø)`
src/passa/cli/add.py	`0% <ø> (ø)`
src/passa/internals/_pip_shims.py	`72.97% <ø> (ø)`
src/passa/cli/remove.py	`0% <ø> (ø)`
src/passa/actions/sync.py	`0% <ø> (ø)`
src/passa/cli/upgrade.py	`0% <ø> (ø)`
src/passa/models/environments.py	`22.67% <0%> (ø)`
src/passa/models/providers.py	`61.29% <0%> (ø)`
src/passa/internals/utils.py	`64.91% <0%> (ø)`
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed2038...4097493. Read the comment docs.

frostming · 2019-09-26T04:04:40Z

Creating virtualenv for every test case is a big performance killer in testing.
I am considering to design a new (un)installation interface so that we can get a full mocked (un)installation and get rid of venv.

frostming · 2019-09-26T13:46:29Z

Whoa, after mocking installation, the time cost is reduced by 60%!

Before change, metasets have a large number of duplicate items. and the size grows exponentially

frostming · 2019-09-28T14:23:51Z

I am not apt to make huge PRs, so if the review is done we can start merging stuff. No need to have a full test suite at this point. Especially there are some bugfixes that are worth merging into the master. Do we need to cherry-pick?

Fix marker duplication

Fix #67

techalchemy added 30 commits October 3, 2018 01:36

Add initial tests

17fdda6

Signed-off-by: Dan Ryan <dan@danryan.co>

Clean up options and add virtualenv module

4186a0c

Signed-off-by: Dan Ryan <dan@danryan.co>

Add tests (clean is still failing)

c431ae6

Signed-off-by: Dan Ryan <dan@danryan.co>

Wheel installation into virtualenv works

bf4fa23

Signed-off-by: Dan Ryan <dan@danryan.co>

Update setup.cfg

ac6929b

Signed-off-by: Dan Ryan <dan@danryan.co>

Implement working versions of clean and install inside virtualenvs

194cd50

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix cleaning working set and messaging

8ee990e

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix tests

b1a7bf7

Signed-off-by: Dan Ryan <dan@danryan.co>

Update tox and add mork, installer and virtualenv dependencies

2a40250

Signed-off-by: Dan Ryan <dan@danryan.co>

Swap to mork implementation for testing

afe8e51

Signed-off-by: Dan Ryan <dan@danryan.co>

Update CI configs

28bf2f0

Signed-off-by: Dan Ryan <dan@danryan.co>

Add deprecation warning ignores to test runners

57bac36

Signed-off-by: Dan Ryan <dan@danryan.co>

Add project fixtures, venv support

06f1af8

Signed-off-by: Dan Ryan <dan@danryan.co>

Add clean, install and lock tests

7ed8fbe

Signed-off-by: Dan Ryan <dan@danryan.co>

Add sync and remove tests

c5a516a

Signed-off-by: Dan Ryan <dan@danryan.co>

Monkeypatch distlib metadata to work with version 2.1

d6e2aa4

Signed-off-by: Dan Ryan <dan@danryan.co>

Update lockfile

246eccd

Signed-off-by: Dan Ryan <dan@danryan.co>

Update pipfile and lockfile

1f48d03

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix packing

4dc19fd

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix package task

b1f2e17

Signed-off-by: Dan Ryan <dan@danryan.co>

Add LRU cache for cacheable function calls

c47b7a6

Signed-off-by: Dan Ryan <dan@danryan.co>

Drop markers from editable requirements

404b9e0

- Also clean up python specifiers Signed-off-by: Dan Ryan <dan@danryan.co>

Add PySpec object to handle comparison and consolidation

0ffc28e

- Also add magic methods to MetaSet object - Super fast and efficient now due to set comparisons - Old method had sometimes thousands of the same pyspecs - This consolidates as it builds Signed-off-by: Dan Ryan <dan@danryan.co>

Cleanup

2345480

Signed-off-by: Dan Ryan <dan@danryan.co> Test fixes Signed-off-by: Dan Ryan <dan@danryan.co> Fix specifier dedup logic Signed-off-by: Dan Ryan <dan@danryan.co> Fix import Signed-off-by: Dan Ryan <dan@danryan.co> Fix tox Signed-off-by: Dan Ryan <dan@danryan.co>

update lockfile?

703c8c5

Signed-off-by: Dan Ryan <dan@danryan.co>

Finalize marker intersection logic

85de00e

Signed-off-by: Dan Ryan <dan@danryan.co>

Clean up PySpec intersection methods

2c7f670

Signed-off-by: Dan Ryan <dan@danryan.co>

Force upgrades

3c9a86c

Signed-off-by: Dan Ryan <dan@danryan.co>

Add assertion for debugging travis

d26f485

Signed-off-by: Dan Ryan <dan@danryan.co>

techalchemy and others added 5 commits October 3, 2018 22:11

Fix specifier math

18e6501

Signed-off-by: Dan Ryan <dan@danryan.co>

Fix mork invocations

fc759b3

Signed-off-by: Dan Ryan <dan@danryan.co>

Merge branch 'master' into fix-marker-duplication

e622517

Signed-off-by: Dan Ryan <dan@danryan.co>

mocked pypi server

49aa390

Remove finder argument to build_wheel

62d5769

frostming force-pushed the add-tests-frost branch from b8e5f31 to 674f9b7 Compare September 20, 2019 05:56

frostming force-pushed the add-tests-frost branch from 436a30e to 6517a33 Compare September 26, 2019 13:08

frostming force-pushed the add-tests-frost branch from c55ee5c to 51542c8 Compare September 27, 2019 05:37

frostming marked this pull request as ready for review September 28, 2019 13:25

frostming added 12 commits September 28, 2019 22:20

setup github actions

7d93589

Refactor synchronizers to allow easy mock

0f14f8e

update pipfiles

086921b

more patches

586c90c

allow makedir fail when creating cache

289c4a3

fix argument error

cd05bd2

Deduplicate early to speed up metadata setting

cf4ee23

Before change, metasets have a large number of duplicate items. and the size grows exponentially

VCS download mocked!

8249ae4

use patched yaspin

f9af54a

add environment for install manager

a0835bd

Fix installating and locking for editable pkgs

7c96e4f

add some news

2682a8e

frostming force-pushed the add-tests-frost branch from b332052 to 2682a8e Compare September 28, 2019 14:20

frostming and others added 4 commits September 30, 2019 09:36

merge branch 'add-tests-frost'

8024741

merge conflicts

bc0b1f4

Merge pull request #59 from sarugaku/fix-marker-duplication

1644593

Fix marker duplication

Reliably copy the requirement object

4097493

Fix #67

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration tests#66

Add integration tests#66
frostming wants to merge 52 commits intoadd-testsfrom
add-tests-frost

frostming commented Sep 20, 2019

Uh oh!

codecov bot commented Sep 20, 2019 •

edited

Loading

Uh oh!

frostming commented Sep 26, 2019 •

edited

Loading

Uh oh!

frostming commented Sep 26, 2019

Uh oh!

frostming commented Sep 28, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

frostming commented Sep 20, 2019

Uh oh!

codecov bot commented Sep 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

frostming commented Sep 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frostming commented Sep 26, 2019

Uh oh!

frostming commented Sep 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Sep 20, 2019 •

edited

Loading

frostming commented Sep 26, 2019 •

edited

Loading

frostming commented Sep 28, 2019 •

edited

Loading