Skip to content

Conversation

@cduong11
Copy link
Contributor

Attempt to address issue #137

  • Enable the option to pass a FASTA file to SAMTOOLS_MERGE to avoid the lookup behaviour of samtools.
  • Generate the REF_PATH variable based on the original process outlined here using the seq_cache_populate.pl script.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@cduong11
Copy link
Contributor Author

Hi @tkchafin, this approach is my proposal for handling CRAM files with samtools. It ensures that the reference FASTA is not retrieved multiple times and prevents errors when working with aligned CRAM inputs. Let me know if you'd like any further changes!

@cduong11 cduong11 requested a review from tkchafin October 24, 2024 09:39
@muffato muffato marked this pull request as draft April 29, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant