fix: avoid infinite recursion when recording body with Readfrom#86
Merged
fix: avoid infinite recursion when recording body with Readfrom#86
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical infinite recursion bug in the bodyWriter.ReadFrom method. The issue occurred when io.Copy was called with a bodyWriter that implements both io.Writer and io.ReaderFrom, causing io.Copy to repeatedly invoke ReadFrom, which in turn called io.Copy again.
Changes:
- Fixed infinite recursion by wrapping the writer in an anonymous struct that only exposes
io.Writerinterface
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================
==========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.