Skip to content

Conversation

@tshepang
Copy link
Member

@tshepang tshepang commented Jan 7, 2026

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2026

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

📌 Commit 5b4dbe0 has been approved by wesleywiser

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2026
@bors
Copy link
Collaborator

bors commented Jan 7, 2026

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

📌 Commit 5b4dbe0 has been approved by wesleywiser

It is now in the queue for this repository.

Kobzol added a commit to Kobzol/rust that referenced this pull request Jan 7, 2026
rustc book: fix grammar

It was added in ddee45e ([here](https://github.com/rust-lang/rust/pull/97802/changes#diff-85dc642a7bdad363a9e37d2491230280fcd977391ba7a242bda2da9ddb55f654) to be specific) when SIGPIPE was controlled with an attribute on `fn main()` which meant it could also be combined with `#[rustc_main]`:

    #[unix_sigpipe = "sig_dfl"]
    #[rustc_main]
    fn rustc_main() {

The test stopped being needed in cde0cde when `#[unix_sigpipe = "..."]` was replaced by `-Zon-broken-pipe=...`. And it will not be needed when `-Zon-broken-pipe=...` is replaced by an Externally Implementable Item (see rust-lang#150591). Let's remove this test.

Tracking issue:
- rust-lang#150588
rust-bors bot added a commit that referenced this pull request Jan 7, 2026
Rollup of 5 pull requests

Successful merges:

 - #150696 (enrich error info when tries to dlopen Enzyme)
 - #150721 (Deprecated doc intra link)
 - #150747 (tests/ui/runtime/on-broken-pipe/with-rustc_main.rs: Not needed so remove)
 - #150761 (rustc book: fix grammar)
 - #150775 (Move issue-12660 to 'ui/cross-crate/ with a descriptive name)

r? @ghost
rust-bors bot added a commit that referenced this pull request Jan 7, 2026
Rollup of 4 pull requests

Successful merges:

 - #150738 (Factorize `triagebot.toml` float parsing mentions with a glob matching)
 - #150761 (rustc book: fix grammar)
 - #150764 (Convert static lifetime to an nll var)
 - #150775 (Move issue-12660 to 'ui/cross-crate/ with a descriptive name)

r? @ghost
@rust-bors rust-bors bot merged commit dbf905f into rust-lang:main Jan 8, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 8, 2026
rust-timer added a commit that referenced this pull request Jan 8, 2026
Rollup merge of #150761 - patch-1, r=wesleywiser

rustc book: fix grammar
@tshepang tshepang deleted the patch-1 branch January 8, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants