Skip to content

resolve: Factor out and document the glob binding overwriting logic #150502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
petrochenkov wants to merge 5 commits into
base: main
Choose a base branch
from
Open

resolve: Factor out and document the glob binding overwriting logic #150502

petrochenkov wants to merge 5 commits into from

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Dec 30, 2025

Also, avoid creating fresh bindings and overwriting bindings in modules to update some fields in NameBindingData, when possible.
Instead, change the fields directly in NameBindingData using cells.

Unblocks #149195.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
resolve: Factor out and document the glob binding overwriting logic
e9ac522
@petrochenkov
resolve: Update NameBindingData::warn_ambiguity in place
ea983b4 
instead of creating fresh bindings.
@petrochenkov
resolve: Update NameBindingData::vis in place
b6c9169 
instead of overwriting bindings in modules.
@petrochenkov
resolve: Tweak overwriting with ambiguous globs
a5413a8 
Do not overwrite unless necessary, and combine both globs instead of losing the first one.
@petrochenkov
resolve: Update NameBindingData::ambiguity in place
11cf5db 
instead of creating fresh bindings, except in one case.
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Dec 30, 2025

r? @yaahc maybe

@rustbot rustbot assigned yaahc and unassigned lcnr Dec 30, 2025
@petrochenkov petrochenkov mentioned this pull request Dec 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@yaahc yaahc

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov @rustbot @rust-log-analyzer @yaahc @lcnr