Skip to content

Conversation

@qb42
Copy link
Contributor

@qb42 qb42 commented Dec 30, 2025

3 recently demoted targets had their entries moved to the tier 3 table without adjusting for the extra "host" column, this PR adds an empty column so they display correctly.

2 recently promoted targets had the opposite problem, also fixed.

While doing that I noticed that empty columns were represented inconsistently throughout the file so I normalized them all to be 2 spaces, which seemed to be the majority opinion (139 instances vs 5 for 1 space and 19 for 3 spaces).

Closes: #150499

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kobzol
Copy link
Member

Kobzol commented Dec 30, 2025

It would be great to write some test that parses this Markdown and ensures that the table format is correct. Maybe it could live in src/tools/tidy? (doesn't need to be in this PR)

@ChrisDenton
Copy link
Member

Tbh I'd rather we go in the opposite direction and have the tables be automatically generated from metadata. But perhaps testing the markdown is a better short term solution.

@workingjubilee
Copy link
Member

Thanks. As my colleagues note there's a larger improvement to be had here but right now, this change seems fine. No reason to pressgang someone sending a typo fix into making a larger PR.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 30, 2025

📌 Commit 841091b has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2025
bors added a commit that referenced this pull request Dec 30, 2025
…uwer

Rollup of 3 pull requests

Successful merges:

 - #150058 (Enable file locking support for Hurd)
 - #150420 (Do not spill operand debuginfo to stack for AArch64 SVE predicates `<vscale x N x i1>` where `N != 16`)
 - #150501 (Fix Typos in Platform Support Tables)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 342a1ac into rust-lang:main Dec 31, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 31, 2025
rust-timer added a commit that referenced this pull request Dec 31, 2025
Rollup merge of #150501 - qb42:patch-1, r=workingjubilee

Fix Typos in Platform Support Tables

3 recently demoted targets had their entries moved to the tier 3 table without adjusting for the extra "host" column, this PR adds an empty column so they display correctly.

2 recently promoted targets had the opposite problem, also fixed.

While doing that I noticed that empty columns were represented inconsistently throughout the file so I normalized them all to be 2 spaces, which seemed to be the majority opinion (139 instances vs 5 for 1 space and 19 for 3 spaces).

Closes: #150499
@qb42 qb42 deleted the patch-1 branch December 31, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tier 3 Platform Support Table is Misformatted

7 participants