-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Fix Typos in Platform Support Tables #150501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
|
It would be great to write some test that parses this Markdown and ensures that the table format is correct. Maybe it could live in |
|
Tbh I'd rather we go in the opposite direction and have the tables be automatically generated from metadata. But perhaps testing the markdown is a better short term solution. |
|
Thanks. As my colleagues note there's a larger improvement to be had here but right now, this change seems fine. No reason to pressgang someone sending a typo fix into making a larger PR. @bors r+ rollup |
…uwer Rollup of 3 pull requests Successful merges: - #150058 (Enable file locking support for Hurd) - #150420 (Do not spill operand debuginfo to stack for AArch64 SVE predicates `<vscale x N x i1>` where `N != 16`) - #150501 (Fix Typos in Platform Support Tables) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #150501 - qb42:patch-1, r=workingjubilee Fix Typos in Platform Support Tables 3 recently demoted targets had their entries moved to the tier 3 table without adjusting for the extra "host" column, this PR adds an empty column so they display correctly. 2 recently promoted targets had the opposite problem, also fixed. While doing that I noticed that empty columns were represented inconsistently throughout the file so I normalized them all to be 2 spaces, which seemed to be the majority opinion (139 instances vs 5 for 1 space and 19 for 3 spaces). Closes: #150499
3 recently demoted targets had their entries moved to the tier 3 table without adjusting for the extra "host" column, this PR adds an empty column so they display correctly.
2 recently promoted targets had the opposite problem, also fixed.
While doing that I noticed that empty columns were represented inconsistently throughout the file so I normalized them all to be 2 spaces, which seemed to be the majority opinion (139 instances vs 5 for 1 space and 19 for 3 spaces).
Closes: #150499