-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Expose kernel launch options as offload intrinsic args #150444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter |
|
@kevinsala it would be nice to have an example in our docs where giving the same dimensions as runtime value (e.g. via command line) vs giving them at compile time (like in the example here) have some measurable perf difference. I assume it's hard to artificially come up with an example exactly for that, or do you know how to get one? |
|
@ZuseZ4 I'll try to find an example. |
efcf026 to
330d170
Compare
|
As per discussion with offload devs, this should be u32 not i32, otherwise lgtm for now. Once we have a proper macro frontend for our intrinsic we can also consider changing it to |
330d170 to
6e0d0da
Compare
This comment has been minimized.
This comment has been minimized.
6e0d0da to
33d39a9
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Allows modifying the workgroup and thread grid dimensions directly from the intrinsic call.
r? @ZuseZ4