Skip to content

do not suggest method call removal if it changes receiver type #150441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fee1-dead wants to merge 2 commits into
base: main
Choose a base branch
from
Open

do not suggest method call removal if it changes receiver type #150441

fee1-dead wants to merge 2 commits into from

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Dec 27, 2025 •
edited by rustbot
Loading

Fixes #149487, cc @estebank

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 28, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 29, 2025

Not comfortable enough with this part of the codebase to review, rerolling
r? compiler

@rustbot rustbot assigned lcnr and unassigned JonathanBrouwer Dec 29, 2025
@fee1-dead fee1-dead added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnr lcnr

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Diagnostic for .unwrap_or_default() suggests removing unrelated code

5 participants

@fee1-dead @rustbot @rust-log-analyzer @JonathanBrouwer @lcnr