Update to Rust 1.82 #4089
Merged
Update to Rust 1.82 #4089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately missed some of this when updating to Rust 1.81
As with project paths, we do not want these to have the paths from the user who runs `update-rustc.sh`, but some totally generic path.
chriskrycho
force-pushed
the
rust-1.82
branch
from
7e0b1d5 to
9650137
Compare
chriskrycho
commented
Nov 5, 2024
Contributor
Author
There was a problem hiding this comment.
Deleted because inlined.
chriskrycho
commented
Nov 5, 2024
Contributor
Author
There was a problem hiding this comment.
Deleted because it was actually unused!
chriskrycho
commented
Nov 5, 2024
| @@ -7,7 +7,7 @@ error[E0005]: refutable pattern in local binding | |||
| | ^^^^^^^ pattern `None` not covered | |||
| | | |||
| = note: `let` bindings require an "irrefutable pattern", like a `struct` or an `enum` with only one variant | |||
| = note: for more information, visit https://doc.rust-lang.org/book/ch19-02-refutability.html | |||
| = note: for more information, visit https://doc.rust-lang.org/book/ch18-02-refutability.html | |||
Contributor
Author
There was a problem hiding this comment.
For posterity: I am going to let this be as it is, even though it’s “wrong” now, for two reasons.
- Although it doesn't match the book, it will get updated automatically when we bump to a version which includes Update TRPL to add new Chapter 17: Async and Await rust#131859, and then will stay in sync automatically after that.
- I put in redirects in Add HTML-based redirects for previous chapter numbering #4061 so anyone who does follow this will still end up on the correct page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #4062