feat: Add convenience methods for Group::with_title #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using annotate-snippets, I was getting annoyed with the redundancy of
Group::with_title(... primary_title())and figured we could allow people to bypass that. With rustfmt, I also feel like the code more closely virtually matches the output.We could also put
fn elementon aLevelas a shortcut forGroup::with_levelbut I figured that was an uncommon enough of a case to not provide a shortcut for so we don't accidentally steer users in the wrong direction.The main downside is that this shortcut only works if there are elements. I have mixed feelings about what approach to take for title-only groups.