Fix reading files with SD1700 in company descriptive date field#66
Fix reading files with SD1700 in company descriptive date field#66henriquegasques merged 3 commits intorubyritas:masterfrom henriquegasques:fix_reading_files_with_SD1700_in_company_descriptive_date_field
Conversation
|
Hi @jm81, if you can, please take a look at this proposed fix and let me know what you think. I know you are not actively maintaining this project, but it would be nice to have this merged if possible. Also, what would be the steps to become a maintainer? I'm currently using this gem at work, and a few colleagues and I would like to help maintain it. |
|
|
|
@adamdecaf That makes complete sense, specially to keep backwards compatibility since |
|
@henriquegasques The change makes sense to me. Since it looks like you might still be working on it, I haven't merged yet. I am inviting you as a collaborator so you can merge whenever if it's ready and you don't want to wait on me. I'd be happy to add @adamdecaf or anyone else as a collaborator too. As far as taking over or helping out with maintaining, that would be awesome. I can give collaborator access as needed or if you'd like to put the official repo on another account, I can just update the README to point there. And then I could add you as an owner of the gem on rubygems.org. If you have an account there and want me to so, just let me know your email or handle for rubygems. But you can also just let me know when it's ready for a new gem version to be pushed and I can do so though it might take me a couple days. |
adamdecaf
left a comment
There was a problem hiding this comment.
This handles SD values a lot better now.
|
I could be a collaborator here, but I've already got an ACH project to maintain. I just watch this repository to see what other ACH projects are up to and help out where I can. |
|
I've pushed version 0.6.1 to rubygems.org |
Problem
Reading a file with with 'SDxxxx' in the company descriptive date field of the batch header was trying to parse the string to a Date, causing it to be
nilSolution
Return the actual value if it doesn't parse to a Date, so it can be formatted when building the batch header.