Add README comment about File Creation Date timezones in file header#63
Merged
jm81 merged 1 commit intorubyritas:masterfrom Nov 4, 2022
Conversation
We had a bank we work with get persnickety about the File Creation Date being a Saturday for files sent to them on Friday nights This seemed like it was worth a README warning but not a breaking change to the default value, but let me know if you can think of any code changes to accomodate this for everyone! We ended up using in our rails codebase that uses this gem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a bank we work with get persnickety about the File Creation Date being a Saturday for files sent to them on Friday nights
This seemed like it was worth a README warning but not a breaking change to the default value, but let me know if you can think of any code changes to accomodate this for everyone!
We ended up using
Time.zone.nowin our rails codebase that uses this gem