Fix error when variable is computed #5404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$input-border-width is set to `var(--bs-border-width)` which cannot be directly multiplied
Collaborator
|
This seems to have addressed my issue -- thanks! |
Collaborator
|
Any guess how I can reproduce this on my system? I haven't run into it, so hard to verify that it is fixed :) |
awwaiid
approved these changes
Nov 30, 2025
Collaborator
awwaiid
left a comment
awwaiid
left a comment
There was a problem hiding this comment.
Well I confirm that it doesn't make it worse and the documentation agrees and this is the only instance.
Contributor
|
@jonny5: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_form_floating_labels.scssis based on Bootstrap 4. In Bootstrap 4 the variableinput-border-widthwas defined as a set amount of pixels, it is nowvar(--bs-border-width)which needscalcto multiply by 2.Type of change