Skip to content

Conversation

@scottserok
Copy link
Contributor

@scottserok scottserok commented Aug 19, 2019

Adds test coverage for new minor versions of Ruby 2. Updates Ruby 2.3, 2.4,
and 2.5 patch version to the latest available.

Adds test coverage for newer versions of Ruby. Updates Ruby 2.3, 2.4,
and 2.5 patch version to the latest available.
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use "2.4", "2.5" and "2.6"?

We can remove "2.3.x" because 2.3.x is EOL.

We can omit micro version to use the latest release.

When you omit the patch version from the rvm configuration, Travis CI
will use the latest patch version available for that minor version of
Ruby.  i.e. specify version 2.6 will download 2.6.3 as of this commit.
@scottserok
Copy link
Contributor Author

Thanks for the feedback @kou. I have implemented the requested changes. Let me know if there's anything more I can do to help.

@scottserok scottserok changed the title Adds Ruby 2.5.5 and 2.6.3 to Travis CI configuration Adds Ruby 2.5 and 2.6 to Travis CI configuration Aug 19, 2019
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kou kou merged commit ce29d09 into ruby:master Aug 20, 2019
@scottserok scottserok deleted the update_travis_config branch August 20, 2019 02:07
@knapo
Copy link

knapo commented Aug 21, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants