error.c: Let Exception#inspect inspect its message#4857
Merged
mame merged 1 commit intoruby:masterfrom Jun 7, 2022
Merged
Conversation
... only when the message string has a newline.
`p StandardError.new("foo\nbar")` now prints `#<StandardError: "foo\nbar">'
instead of:
#<StandardError:
bar>
[Bug #18170]
mame
force-pushed
the
let-exception-inspect-inspects-error-message
branch
from
641ede7 to
107d468
Compare
jeremyevans
approved these changes
Mar 30, 2022
Contributor
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
This looks fine to me. I wonder if it would be a good idea to check for other characters (e.g. \0) as well, but I think starting with \n is fine, and that is what matz approved.
st0012
added a commit
to st0012/debug
that referenced
this pull request
Jun 9, 2022
Main reason: if ruby/ruby#4857 is implemented, using `#inspect` will lose the newlines from the formatted message. Another reason: test frameworks usually fetch exceptions' class name and message separately to compose the full message, instead of just calling `#inspect`. So our test framework should be implemented similarly.
st0012
added a commit
to st0012/debug
that referenced
this pull request
Jun 9, 2022
This will avoid tests from failing because of format changes like ruby/ruby#4857
st0012
added a commit
to st0012/debug
that referenced
this pull request
Jun 9, 2022
This will avoid tests from failing because of format changes like ruby/ruby#4857
st0012
added a commit
to st0012/debug
that referenced
this pull request
Jun 13, 2022
This will avoid tests from failing because of format changes like ruby/ruby#4857
st0012
added a commit
to st0012/debug
that referenced
this pull request
Jul 5, 2022
Main reason: if ruby/ruby#4857 is implemented, using `#inspect` will lose the newlines from the formatted message. Another reason: test frameworks usually fetch exceptions' class name and message separately to compose the full message, instead of just calling `#inspect`. So our test framework should be implemented similarly.
st0012
added a commit
to st0012/debug
that referenced
this pull request
Jul 5, 2022
This will avoid tests from failing because of format changes like ruby/ruby#4857
ko1
pushed a commit
to ruby/debug
that referenced
this pull request
Jul 5, 2022
Main reason: if ruby/ruby#4857 is implemented, using `#inspect` will lose the newlines from the formatted message. Another reason: test frameworks usually fetch exceptions' class name and message separately to compose the full message, instead of just calling `#inspect`. So our test framework should be implemented similarly.
ko1
pushed a commit
to ruby/debug
that referenced
this pull request
Jul 5, 2022
This will avoid tests from failing because of format changes like ruby/ruby#4857
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
p StandardError.new("foo\nbar")now printsinstead of:
[Bug #18170]