Fix RDoc::Attr#add_alias handling of aliased attribute accessor#1605
Merged
tompng merged 1 commit intoruby:masterfrom Feb 9, 2026
Merged
Conversation
extern-c
requested a deployment
to
fork-preview-protection
GitHub Actions
Waiting
extern-c
requested a deployment
to
fork-preview-protection
GitHub Actions
Waiting
Ensure aliased attributes get the correct access type ('R' or 'W') instead of always being marked as 'RW'.
extern-c
force-pushed
the
fix-add-alias-for-attribute-accessor
branch
from
b12db40 to
82ec898
Compare
extern-c
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
Collaborator
|
🚀 Preview deployment available at: https://0f0fb6f2.rdoc-6cd.pages.dev (commit: 82ec898) |
tompng
pushed a commit
that referenced
this pull request
Feb 17, 2026
…ypes (#1612) This is a continuation of #1605. The original PR ensured that aliased attr_accessor attributes have the correct access type ('R' or 'W') instead of always being 'RW'. This PR adds test cases to verify that aliased reader and writer `RDoc::Attr`s are created with the correct access type ('R' or 'W').
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure aliased attr_accessor attributes have the correct access type ('R' or 'W') instead of always being 'RW'.
For more details on the issue being addressed, see #1286 (comment).