Remove all internal frames from a backtrace #1106
Merged
+23
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby 3.5, the debug inspector API returns a raw backtrace, so irb/debug needs to remove not only `<internal:prelude>` but also all internal frames.
In ruby 3.5, `Kernel#caller_location` will not include `<internal:xxx>` frames. Instead, it will use its caller-side location for an internal frame. ruby/ruby#13238 This change updates the expected values of backtraces in irb test to support the behavior change.
Member
Author
|
The CI fails because ruby/ruby#13238 is not merged. But to merge that PR to ruby/ruby, this PR must be merged to ruby/irb... Let me merge this now. Then I will merge that PR to ruby/ruby, and trigger ruby-dev-builder so that setup-ruby can fetch the new ruby master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.5, the debug inspector API returns a raw backtrace, so irb/debug needs to remove not only
<internal:prelude>but also all internal frames.