Skip to content

Fix broken history command with -g #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
st0012 merged 1 commit into from
Dec 29, 2024
Merged

Fix broken history command with -g #1057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/irb/command/history.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class History < Base

def execute(arg)

if (match = arg&.match(/(-g|-G)\s+(?<grep>.+)\s*\n\z/))
if (match = arg&.match(/(-g|-G)\s+(?<grep>.+)\s*\z/))
grep = Regexp.new(match[:grep])
end

Expand Down
6 changes: 6 additions & 0 deletions test/irb/test_command.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,12 @@ def test_history_grep
puts x
...
EOF
assert_not_include(out, <<~EOF)
foo
EOF
assert_not_include(out, <<~EOF)
bar
EOF
assert_empty err
end

Expand Down
Loading