Support passing rewriters to CLI#47
Conversation
|
Thanks for the PR! I will take a look later this week. |
palkan
left a comment
There was a problem hiding this comment.
Great job 👍 Thank you!
Could you please add a change log entry?
|
Thank you! I've just added change log entry. |
|
|
||
| ## master | ||
|
|
||
| - Support passing rewriters to CLI. ([@sl4vr][]) |
There was a problem hiding this comment.
👍
Could you please also add the actual link to the bottom of this file? (Right now it's not working, cause shortcut is not defined)
There was a problem hiding this comment.
Oops I thought it's Github feature or something 🙄
palkan
left a comment
There was a problem hiding this comment.
Thanks a lot!
Awesome work 👍
Marked task as done: https://cultofmartians.com/tasks/ruby-next-cli-rewriters.html#task (check if everything is correct).
And could you please send me your mailing address to my e-mail (should be on my GitHub profile), so we'll we able to send you some stuff someday)
What is the purpose of this pull request?
Support passing rewriters to CLI - #42
What changes did you make? (overview)
--list-rewritersand--rewriteoptions fornextifycommand.Is there anything you'd like reviewers to focus on?
I didn't dig into that, just supposed rewriters gonna rewrite. Also it just failed for me in other case.
Also this implementation requires
--edgeand--proposedflags to use and even list corresponding rewriters. If it's not supposed to be so, I can change that.Checklist