Open
Conversation
Collaborator
|
On my MacBook Pro M3:
I really appreciate you taking the time to explore this! But so far, I don’t think it’s worth it. Maybe related note: My dream is to switch from Flow to TypeScript and use ESM instead of CommonJS. It feels like moving the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findClosedElmJson, as recursion in JS is not optimal.--report=jsonor--report=junit.This makes the startup time faster, as demonstrated when running using
--help(usinghyperfine):However, when running regular tests (plain
elm-test, onelmcraft/core-extra), I'm getting worse results:I don't know if my benchmarking is wrong or if lazy imports makes things worse when they're spread out and most of them end up being called. If I end up running
hyperfinewith benchmarks reversed, I usually get diverging results :/However,
mochatests reports the duration of slow tests, and when comparingmocha testson both branches, the new version does seem to yield faster tests.