[fix] Add quotes for Password string since it may contain special chars.#96
Merged
WtfJoke merged 1 commit intortcTo:developfrom Mar 15, 2016
Merged
Conversation
Member
|
Sure thing, makes totally sense to quote the password in that case. Thank you, for your contribution :) |
WtfJoke
added a commit
that referenced
this pull request
Mar 15, 2016
[fix] Add quotes for Password string since it may contain special chars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a password contains a special character like
#, the login function can fail as it tries to terminate the current expression.