Replace custom quote function with shlex.quote#107
Replace custom quote function with shlex.quote#107WtfJoke merged 1 commit intortcTo:developfrom pbhandari:fix/quoting-logic
Conversation
The custom written `shell.quote` function was causing issues with it not correctly escaping some characters. As Python 3.3+ comes with a `quote` function in the `shlex` module, we use that in place of the custom `quote` function. Fixes issue #97.
|
@WtfJoke: if you're still skeptical about using |
|
Sorry about my late response. I'll have a look at it during the next weeks/days. But I think we can merge that without any problems. |
|
Looks good, thank you :) |
|
I would like to say, that this shlex.quote thing completely messed up the script for me. I had to remove all shlex again. It was executing commands like: scm login -r -u '"'"''"'"' -P '"'"''"'"' I manually replaced all shlex, and put in " everywhere. That worked. |
|
Ok, thank you for the info. I will revert this. |
I reset the code to the point without merging this pull request |
The custom written
shell.quotefunction was causing issues with it notcorrectly escaping some characters. As Python 3.3+ comes with a
quotefunction in the
shlexmodule, we use that in place of the customquotefunction.Fixes issue #97.