Support directly including htmlDependency() objects in rmarkdown
#376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #375, making it possible to include an
htmlDependency()simply by calling it in an R chunk where it's handled byknit_print().Previously, users had to include the dependency in a
tagList()or atagto use theknit_print.shiny.tagmethod. Fortunately, that same method works forhtmlDependency()objects too.This small R Markdown document will now show the pencil icon, where previously it would print the font awesome dependency and no icon would be visible.
This is a slightly breaking change in the sense that users who were previously printing the html dependency will now need to use
print()explicitly to show the object structure. In general, I think the new behavior is preferable.