Add support for building and serializing Radiotap values #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the fields of the Radiotap struct are public, and the struct already implements Default, so while it *is* possible to build values in code, doing so is inconvenient: the Header value has to be populated correctly based on which fields are set and in which order they appear in the serialized format. A dedicated builder struct allows to do it fluently and prevent potential mistakes. This requires minimal changes to the existing API, most of which are optional: * Kind::bit() offers a conversion from an enum variant back to a bit number value; that value defines the order in which fields appear in the serialized format * Radiotap::build() is a helper function that starts the build process * Implementing Default makes passing flag values slightly less verbose The primary motivation for this change is to allow building Radiotap values programmatically and later serialize them to the wire format.
Add a new method called `unparse()` that serializes a Radiotap value into a stream of bytes according to the rules of the Radiotap wire format. In conjunction with the `build()` method this allows to build Radiotap values programmatically, e.g. for packet injection. Adding a new test uncovered a few issues in the existing code related to the precedence of bitwise operations that are now fixed.
malor
changed the title
|
I'd love to see this too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @rossmacarthur!
I was playing around with the code and I wonder what you think about the idea of adding support for:
Radiotapvalues programmaticallyRadiotapvalues into the wire formatThe former is sort of already possible by the nature of having all fields of the
Radiotapstruct declared as public, but it's also annoying as theHeadervalue needs to be updated accordingly afterwards. Also, some of the types do not currently implementDefaultwhich makes it tedious. A builder struct should make this straightforward.And then we can implement serialization on top of that to support the use case of building Radiotap headers for packet injection.
Thank you!