Make array and object prototype singletons immutable for now#4142
Merged
lukastaegert merged 3 commits intomasterfrom Jun 17, 2021
Merged
Make array and object prototype singletons immutable for now#4142lukastaegert merged 3 commits intomasterfrom
lukastaegert merged 3 commits intomasterfrom
Conversation
lukastaegert
force-pushed
the
immutable-prototypes
branch
from
4d12fd1 to
8383cf9
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#immutable-prototypesor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4142 +/- ##
==========================================
+ Coverage 98.13% 98.28% +0.15%
==========================================
Files 201 201
Lines 7116 7116
Branches 2083 2084 +1
==========================================
+ Hits 6983 6994 +11
+ Misses 64 58 -6
+ Partials 69 64 -5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4140
Description
Currently, Rollup treats the Array and Object prototypes as singletons. This is problematic as we are still using a stateful helper class to implement this, which can lead to a memory leak when used in watch mode. This hopefully improves the situation. Note that in the future, we might rework this again if we ever get to the point that we track mutations of globals.