Skip to content

Enhance LogViewer functionality#6

Merged
rock3r merged 1 commit intomasterfrom
improve-log
Feb 5, 2026
Merged

Enhance LogViewer functionality#6
rock3r merged 1 commit intomasterfrom
improve-log

Conversation

@rock3r
Copy link
Owner

@rock3r rock3r commented Feb 5, 2026

  • Modified LogcatLogRepository to return logs in ascending chronological order and improved parsing to handle multi-line entries like stack traces.
  • Updated LogViewerScreen to utilize rememberLazyListState and implement an initial scroll-to-bottom behavior using LaunchedEffect.
  • Improved log readability by appending continuation lines to their parent log entries.

These changes ensure that logs are displayed in a more natural chronological flow while ensuring the most recent entries are immediately visible upon loading.


Note

Medium Risk
Moderate risk: changes log parsing/order and UI scrolling behavior, which can affect log visibility and performance but is not security- or data-critical.

Overview
Improves the in-app log viewer by adding an initial scroll-to-latest behavior via rememberLazyListState + LaunchedEffect, without forcing subsequent auto-scrolling.

Refactors logcat ingestion by extracting a testable LogcatLogParser that skips logcat buffer separator lines and folds multi-line continuations (e.g., stack traces) into the previous LogEntry, and updates LogcatLogRepository.refresh() to use it. Adds unit tests covering parsing, continuation handling, and all log levels, plus a small README wording tweak ("multi-vendor" -> "multivendor").

Written by Cursor Bugbot for commit 940cab8. This will update automatically on new commits. Configure here.

@rock3r rock3r force-pushed the ricoh-firmware-check branch from 063e498 to 3cf1f85 Compare February 5, 2026 01:27
@rock3r rock3r force-pushed the improve-log branch 2 times, most recently from 2d25d52 to 6337a39 Compare February 5, 2026 01:34
Repository owner deleted a comment from cursor bot Feb 5, 2026
@rock3r rock3r force-pushed the ricoh-firmware-check branch from 3cf1f85 to 854a090 Compare February 5, 2026 01:47
@rock3r rock3r changed the base branch from ricoh-firmware-check to master February 5, 2026 01:48
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

- Modified `LogcatLogRepository` to return logs in ascending chronological order and improved parsing to handle multi-line entries like stack traces.
- Updated `LogViewerScreen` to utilize `rememberLazyListState` and implement an initial scroll-to-bottom behavior using `LaunchedEffect`.
- Improved log readability by appending continuation lines to their parent log entries.

These changes ensure that logs are displayed in a more natural chronological flow while ensuring the most recent entries are immediately visible upon loading.
@rock3r rock3r merged commit 90e458e into master Feb 5, 2026
2 checks passed
@rock3r rock3r deleted the improve-log branch February 5, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant