Merged
Conversation
063e498 to
3cf1f85
Compare
2d25d52 to
6337a39
Compare
app/src/main/kotlin/dev/sebastiano/camerasync/logging/LogViewerScreen.kt
Outdated
Show resolved
Hide resolved
3cf1f85 to
854a090
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
app/src/main/kotlin/dev/sebastiano/camerasync/logging/LogcatLogRepository.kt
Outdated
Show resolved
Hide resolved
- Modified `LogcatLogRepository` to return logs in ascending chronological order and improved parsing to handle multi-line entries like stack traces. - Updated `LogViewerScreen` to utilize `rememberLazyListState` and implement an initial scroll-to-bottom behavior using `LaunchedEffect`. - Improved log readability by appending continuation lines to their parent log entries. These changes ensure that logs are displayed in a more natural chronological flow while ensuring the most recent entries are immediately visible upon loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogcatLogRepositoryto return logs in ascending chronological order and improved parsing to handle multi-line entries like stack traces.LogViewerScreento utilizerememberLazyListStateand implement an initial scroll-to-bottom behavior usingLaunchedEffect.These changes ensure that logs are displayed in a more natural chronological flow while ensuring the most recent entries are immediately visible upon loading.
Note
Medium Risk
Moderate risk: changes log parsing/order and UI scrolling behavior, which can affect log visibility and performance but is not security- or data-critical.
Overview
Improves the in-app log viewer by adding an initial scroll-to-latest behavior via
rememberLazyListState+LaunchedEffect, without forcing subsequent auto-scrolling.Refactors logcat ingestion by extracting a testable
LogcatLogParserthat skips logcat buffer separator lines and folds multi-line continuations (e.g., stack traces) into the previousLogEntry, and updatesLogcatLogRepository.refresh()to use it. Adds unit tests covering parsing, continuation handling, and all log levels, plus a small README wording tweak ("multi-vendor" -> "multivendor").Written by Cursor Bugbot for commit 940cab8. This will update automatically on new commits. Configure here.