ROB-1939: do not bolden Holmes result

[nherment]

Tested manually in issue conversation.

[coderabbitai]

Walkthrough

A new parameter single_asterisks_is_bold is added to Transformer.to_github_markdown() with default value True to control single-asterisk bold conversion. Three call sites in model_conversion.py are updated to pass single_asterisks_is_bold=False.

Changes

Cohort / File(s)	Summary
Parameter Addition src/robusta/core/sinks/transformer.py	New parameter single_asterisks_is_bold: bool = True added to to_github_markdown() method signature; final asterisk-bold conversion guarded by this flag.
Call Site Updates src/robusta/core/sinks/robusta/dal/model_conversion.py	Three invocations of Transformer.to_github_markdown() updated to pass single_asterisks_is_bold=False in add_ai_chat_data(), add_ai_analysis_data(), and transformed_sections construction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify all three call sites in model_conversion.py are consistent in passing the new parameter
• Confirm default value True maintains backward compatibility for other callers
• Check whether additional call sites to to_github_markdown() exist elsewhere in the codebase that may need updating

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding a parameter to disable single asterisk bolding in Holmes result markdown output.
Description check	✅ Passed	The description is minimal but relates to the changeset by mentioning manual testing, which is appropriate context for the change.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ROB-1939_holmes_result_corruption

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/robusta/core/sinks/transformer.py (1)

115-133: LGTM! Clean backward-compatible change.

The new parameter correctly gates the single-asterisk-to-bold conversion while preserving the default behavior for existing callers. The implementation is straightforward and correct.

Optional: Consider updating the docstring to mention the asterisk conversion behavior, since it's now a configurable part of the transformation:

     @staticmethod
-    def to_github_markdown(markdown_data: str, add_angular_brackets: bool = True, single_asterisks_is_bold: bool = True) -> str:
-        """Transform all occurrences of slack markdown, <URL|LINK TEXT>, to github markdown [LINK TEXT](URL)."""
+    def to_github_markdown(markdown_data: str, add_angular_brackets: bool = True, single_asterisks_is_bold: bool = True) -> str:
+        """Transform slack markdown to GitHub markdown.
+        
+        Transforms <URL|LINK TEXT> to [LINK TEXT](URL).
+        Optionally converts *text* to **text** when single_asterisks_is_bold is True.
+        """

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 910f863 and 4bcbf70.

📒 Files selected for processing (2)

• src/robusta/core/sinks/robusta/dal/model_conversion.py (2 hunks)
• src/robusta/core/sinks/transformer.py (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/robusta/core/sinks/robusta/dal/model_conversion.py (1)

src/robusta/core/sinks/transformer.py (2)

• Transformer (32-299)
• to_github_markdown (115-133)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: run_tests
• GitHub Check: run_tests
• GitHub Check: Deploy docs

🔇 Additional comments (1)

src/robusta/core/sinks/robusta/dal/model_conversion.py (1)

126-126: LGTM! Consistent application across all Holmes results verified.

Verification confirms all five to_github_markdown calls in the file are correctly handled:

• Lines 126, 149, 157: Holmes results properly disable asterisk-to-bold conversion
• Lines 186, 228: Non-Holmes calls correctly retain default behavior

No missed call sites found.