ROB-1933: remove unused modified_params for holmes tool approval workflow

[nherment]

No description provided.

[coderabbitai]

Walkthrough

Removed the public field modified_params from the ToolApprovalDecision model in base_params.py. No other structural or behavioral changes indicated.

Changes

Cohort / File(s)	Summary of changes
ToolApprovalDecision model src/robusta/core/model/base_params.py	Removed field: modified_params: Optional[Dict[str, Any]] = None from ToolApprovalDecision

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ROB-1933: add support for holmes tool approval fields #1910 — Modifies the same ToolApprovalDecision class/field, indicating a direct code-level relationship.

Suggested reviewers

• arikalon1
• moshemorad

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description is empty and provides no information about the changeset, so it fails to meet the minimal relevance requirement. Without any description, reviewers lack context on the removal of the modified_params field.	Please add a brief description summarizing the removal of the modified_params field from ToolApprovalDecision to clarify the intent and scope of the change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly and concisely describes the primary change removing the modified_params field in the Holmes tool approval workflow and directly reflects the summary of changes. Including the ticket identifier aligns with project conventions without obscuring the main purpose of the pull request.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch rob-1933_holmes_tool_approval_workflow_2

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21db7e8 and ea45d57.

📒 Files selected for processing (1)

• src/robusta/core/model/base_params.py (0 hunks)

💤 Files with no reviewable changes (1)

• src/robusta/core/model/base_params.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: run_tests
• GitHub Check: run_tests
• GitHub Check: Deploy docs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}