-
Notifications
You must be signed in to change notification settings - Fork 288
[ROB-1923] improve irsa docs #1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates the AWS AMP configuration documentation to consolidate IRSA setup into a single “Configure Robusta” step, revise YAML examples with a new toolsets.prometheus/metrics.config block, adjust globalConfig keys (including cluster-wide labels), and renumber Quick Start steps while retaining the Access Keys alternative. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/configuration/metric-providers-aws.rst (1)
88-89: De-duplicate cluster label configuration and standardize quotingKeep labels in one place (recommended: globalConfig.prometheus_additional_labels) and use consistent quoting.
- prometheus_additional_labels: # Add cluster label to all queries - cluster: 'my_cluster_name' + prometheus_additional_labels: # Add cluster label to all queries + cluster: "my_cluster_name"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/configuration/metric-providers-aws.rst(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: run_tests
- GitHub Check: run_tests
- GitHub Check: Deploy docs
- GitHub Check: Deploy docs
🔇 Additional comments (3)
docs/configuration/metric-providers-aws.rst (3)
63-63: Good consolidation of IRSA into a single “Configure Robusta” stepClearer flow; reduces duplication between earlier steps.
75-97: One configuration source of truth: toolset vs env varsWith prometheus/metrics.config present, consider dropping the runner.additional_env_vars (PROMETHEUS_SSL_ENABLED, AWS_SERVICE_NAME, AWS_REGION) to avoid drift. If the chart requires env vars, then remove the duplicated keys from the toolset config instead (as in the patch above). Please confirm which path the Helm chart consumes at runtime.
99-99: Step reference checkEnsure the “Simple Upgrade” anchor still renders as the correct target after renumbering (2. Update Robusta).
No description provided.