Fix and update macOS support, comply with calls deprecated in C++17 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
approved these changes
Aug 2, 2021
Contributor
MichaelEischer
left a comment
MichaelEischer
left a comment
There was a problem hiding this comment.
I've added commits to fix compiling V8 and the Sourcemap library on macOS using a recent Xcode version.
@andreaswendler Can you check whether the sourcemap patch works as intended? I'm not entirely sure about how to correctly use std::bind.
The old code would have resulted in a template specialization failure. However, as these calles are themselves under a template that will not be specialized by our framework right now, the effect was not noticable. The correct usage of std::bind has to specify ALL parameters to the given functor, but can use placeholders to avoid specializing all arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simulator-cli build used to fail on MacOS 11.4 due to the deprecation of std::random_shuffle in C++17.
This has been remedied by replacing the call with a call to std::shuffle.
According to the documentation, Qt5.5.1+ is acceptable. It is now possible to install Qt5.15.2 via Homebrew (
brew install qt@5). This places an acceptable Qt version in a predictable location and therefore Qt installation and discovery can be automated. Qt5 search paths were added to CMake.Documentation was updated to recommend installation of Qt5 via Homebrew, steps were removed and reordered to reflect that Homebrew requires Xcode and Command Line Tools.