Skip to content

Conversation

@navidys
Copy link
Contributor

@navidys navidys commented Apr 7, 2023

Adding an option to disable dropdown primitive automatice selection of an item based on prefix.
Some applications using vim like key binding such as:

  • j: Move down
  • k: Move up
  • l: Move right
  • h: Move left

Dropdown primitive by default will select an input based on input key rune (prefix) that will cause issue with such a key bindings. Its possible to change to parse and change the key even in the application side, however I thought it will be more cleaner to be have an option.

…em (based on prefix)

Signed-off-by: Navid Yaghoobi <navidys@fedoraproject.org>
@navidys
Copy link
Contributor Author

navidys commented Aug 20, 2023

Hi @rivo
Any comment regarding this PR ?

Regards

@rivo
Copy link
Owner

rivo commented Aug 26, 2023

Its possible to change to parse and change the key even in the application side, however I thought it will be more cleaner to be have an option.

Cleaner maybe for your application but more clutter for this package. I'm tending towards not merging this and suggesting that you use SetInputCapture() to change the behaviour if you prefer vim-like navigation here.

I might change my mind if multiple people ask about this or if someone can demonstrate that the current implementation is a real problem. But for now, I'd say I'll keep it the way it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants